Add form question types and categories from plugins #19191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrienClairembault
force-pushed
the
form-questions-from-plugins
branch
5 times, most recently
from
e25eefc to
18b9204
Compare
AdrienClairembault
force-pushed
the
form-questions-from-plugins
branch
from
18b9204 to
5d39816
Compare
cedric-anne
approved these changes
Mar 24, 2025
cedric-anne
approved these changes
Mar 24, 2025
trasher
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Allow a plugin to define its own questions types and categories.
This required very little code for the questions types as we already had a defined interface that the plugin could implement.
It required a bit more changes for the categories as we had a single enum that contained all the types without an interface.
I added an interface and changed the type hints in the code to this new interface as needed.
I also took the liberty to do some small general improvements to the
QuestionTypeManagerservice as I was already changing most of its methods anyway.Screenshots