Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helpdesk forms: add support for conditions on radio/checkbox/dropdown questions #19167

Merged
merged 4 commits into from
Mar 25, 2025
Merged

Helpdesk forms: add support for conditions on radio/checkbox/dropdown questions #19167

merged 4 commits into from
Mar 25, 2025

Conversation

AdrienClairembault
Copy link
Contributor

@AdrienClairembault AdrienClairembault commented Mar 10, 2025 •
edited
Loading

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.

Screenshots

image

@AdrienClairembault AdrienClairembault self-assigned this Mar 10, 2025
@AdrienClairembault AdrienClairembault force-pushed the radio-conditions branch 3 times, most recently from fbe8e05 to 6416c9e Compare March 12, 2025 09:15
@AdrienClairembault AdrienClairembault changed the title Helpdesk forms: add support for conditions on radio type questions Helpdesk forms: add support for conditions on radio/checkbox/dropdown questions Mar 12, 2025
AdrienClairembault
AdrienClairembault commented Mar 19, 2025
View reviewed changes
js/modules/Forms/Condition/Engine.js Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credit to @ccailly for the changes to this file, I stole it from #19139 since we had the same issue here.

@AdrienClairembault AdrienClairembault marked this pull request as ready for review March 19, 2025 13:48
@cedric-anne cedric-anne added this to the 11.0.0 milestone Mar 25, 2025
@trasher trasher merged commit c4b039f into glpi-project:main Mar 25, 2025
7 checks passed
@AdrienClairembault AdrienClairembault deleted the radio-conditions branch March 25, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasher trasher trasher approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

Assignees

@AdrienClairembault AdrienClairembault

Labels
Forms
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrienClairembault @trasher @cedric-anne