Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing source elements to math #216

Merged
merged 5 commits into from
Jul 4, 2022
Merged

Conversation

HassanAkbar
Copy link
Member

  • Parsing sources to math

Old

en:
  sources:
  - type: authoritative
    status: modified
    origin:
      clause: Appendix 1
      original: SI Brochure, 9th edition, 2019, Appendix 1, modified – The definition
        in the SI Brochure has been revised to comply with the IEV rules. The synonym
        "Loschmidt number" and the symbol "<i>L</i>" have been added to Note 2 to
        entry.
    modification: The definition in the SI Brochure has been revised to comply with
      the IEV rules. The synonym "Loschmidt number" and the symbol "<i>L</i>" have
      been added to Note 2 to entry.

New

en:
  sources:
  - type: authoritative
    status: modified
    origin:
      clause: Appendix 1
      original: SI Brochure, 9th edition, 2019, Appendix 1, modified – The definition
        in the SI Brochure has been revised to comply with the IEV rules. The synonym
        "Loschmidt number" and the symbol "stem:[L]" have been added to Note 2 to
        entry.
    modification: The definition in the SI Brochure has been revised to comply with
      the IEV rules. The synonym "Loschmidt number" and the symbol "stem:[L]" have
      been added to Note 2 to entry.

closes #122

gsub("&omega;", "omega")
end

def html_entities_to_stem(input)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment Branch Condition size for html_entities_to_stem is too high. [<0, 36, 0> 36/15]
Method has too many lines. [36/10]

html_entities_to_asciimath(text.decode_html)
end

def html_entities_to_asciimath(input)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment Branch Condition size for html_entities_to_asciimath is too high. [<0, 36, 0> 36/15]
Method has too many lines. [36/10]

)
end

def html_to_asciimath(input)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment Branch Condition size for html_to_asciimath is too high. [<10, 48, 14> 50.99/15]
Cyclomatic complexity for html_to_asciimath is too high. [15/6]
Method has too many lines. [52/10]
Perceived complexity for html_to_asciimath is too high. [14/7]


private

def mathml_to_asciimath(input)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment Branch Condition size for mathml_to_asciimath is too high. [<3, 16, 6> 17.35/15]
Method has too many lines. [22/10]

@HassanAkbar
Copy link
Member Author

Rubocop is working fine locally, but hound is commenting due to this issue -> houndci/hound#1842

@HassanAkbar HassanAkbar marked this pull request as ready for review July 4, 2022 07:56
@HassanAkbar HassanAkbar requested a review from ronaldtse July 4, 2022 07:57
FIGURE_TWO_REGEX = "#{FIGURE_ONE_REGEX}\\s*#{FIGURE_ONE_REGEX}"
IMAGE_PATH_PREFIX = "image::/assets/images/parts"

def parse_anchor_tag(text, term_domain)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method has too many lines. [37/10]

@ronaldtse ronaldtse merged commit c18c9d9 into main Jul 4, 2022
@ronaldtse ronaldtse deleted the parsing_source_elements_to_math branch July 4, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing: some <i> elements aren't parsed into math?
2 participants