-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(input-image): add <SInputImage>
(#356)
#368
Conversation
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 82.13% 80.19% -1.94%
==========================================
Files 147 149 +2
Lines 11792 12079 +287
Branches 516 517 +1
==========================================
+ Hits 9685 9687 +2
- Misses 2107 2392 +285
☔ View full report in Codecov by Sentry. |
wait a second, select image is not responsive after you remove it 👀 |
Oh sit lol |
Whaat... |
I'll fix it separately, some ref issue probably. |
Gotcha. Thanks. Or maybe Histoire issue...? |
It's working for me on Histoire 🤔 |
#369, I was removing and uploading the same image 😅 (I only have like one dummy image on my system 😂) |
Ahhhh I see. And that I wasn't doing 😳 Nice catch. |
<SInputImage>
#356Add
<SInputImage>
. Pretty much followed all issue spec. Adjusted tiny wording of text.Also, this PR contains new
useImageSrcFromFile
composable that can read image src from file.