feat(button)!: add default mode and organize color system
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The `mute` mode now looks slightly different. Use the new option `default` to have the same look as before.
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
- Coverage 82.15% 82.13% -0.02%
==========================================
Files 147 147
Lines 11806 11793 -13
Branches 516 516
==========================================
- Hits 9699 9686 -13
Misses 2107 2107
☔ View full report in Codecov by Sentry. |
brc-dd
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
defaultoption to:modeand organize the color system of the button. This will aline mode of button to other similar component such as<SPill>and<SState>.Also, made huge refactor on how to define css inside
<SButton>. I think I was able to reduce bunch of boilerplates 🔥BREAKING CHANGE
The
mutemode now looks slightly different. Use the new optiondefaultto have the same look as before.