Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): mark onClick as required in TableAction #349

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Oct 3, 2023

No description provided.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 09b1bf1
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/651b82d8809bee0007115d54
😎 Deploy Preview https://deploy-preview-349--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 09b1bf1
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/651b82d8bc629300086cc3df
😎 Deploy Preview https://deploy-preview-349--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brc-dd brc-dd marked this pull request as draft October 3, 2023 02:54
@brc-dd brc-dd marked this pull request as ready for review October 3, 2023 02:56
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fffe693) 84.77% compared to head (09b1bf1) 84.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files         142      142           
  Lines       11379    11379           
  Branches      516      516           
=======================================
  Hits         9647     9647           
  Misses       1732     1732           
Files Coverage Δ
lib/composables/Table.ts 100.00% <100.00%> (ø)
lib/components/STableHeader.vue 92.63% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiaking kiaking merged commit b5d4131 into main Oct 3, 2023
8 of 9 checks passed
@kiaking kiaking deleted the fix/types branch October 3, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants