Holy Days Issue Bugfix #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to GetSpecialDays function. Fix for related Resources test that was pulling back incorrect Holy Day previously. Added new YearInfo test to check bugfix.
benrobot
requested changes
Feb 5, 2021
Comment on lines
+107
to
+117
| [Fact] | ||
| public void GetSpecialDays_HolyDaysWanted() | ||
| { | ||
| var yearInfo = new BadiYearInfo(174); | ||
|
|
||
| var specialDaysList = yearInfo.GetSpecialDays(SpecialDayType.HolyDay_WorkSuspended, HolyDayCode.NawRuz); | ||
| specialDaysList.Count().ShouldEqual(1); | ||
|
|
||
| specialDaysList = yearInfo.GetSpecialDays(SpecialDayType.HolyDay_WorkSuspended, HolyDayCode.Ridvan1); | ||
| specialDaysList.Count().ShouldEqual(1); | ||
| } |
There was a problem hiding this comment.
In addition to asserting the count the test should also assert the correct day and day code are returned.
There was a problem hiding this comment.
You can also change this test from a Fact to a Theory and exhaustively test every possible HolyDayCode
There was a problem hiding this comment.
In just reading the code change proposed, I can't be confident that it is working fully. I'd need to run the code and do a number of other tests to be sure.
So it would be good if you could add more tests and made them more comprehensive. For instance, it would be good to also test calls that will give no result, like .GetSpecialDays(SpecialDayType.HolyDay_Other, HolyDayCode.Ridvan1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for specific Holy Day not getting pulled back when code provided to GetSpecialDays function. HasFlags() check was previously failing, replaced with not-null check instead.
Fix for related Resources test that was pulling back incorrect Holy Day previously. Special Day code was passed incorrectly for Birth of the Bab test case.
Added new YearInfo test to check bugfix.