Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application key support addon #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ovidiul
Copy link

@ovidiul ovidiul commented Jul 20, 2020

It seems that application key support integration is pretty simple, after normal authorisation, the B2 Api sends back the main accountId in the response header which we can use for the rest of the API requests that require the master account ID to be present, like the listBuckets api call.

Could you review this and let me know if we can integrated this inside the main package?

@mlambley
Copy link
Member

mlambley commented Feb 3, 2021

Hi @ovidiul could you please run through the use case for your suggested changes here? It seems that it's aimed towards allowing this module to run with a single-bucket application key, rather than the master key.

The latest version, 1.5.0, allows application keys by letting the dev specify the bucket id, thus removing the need to look up the bucket id by name, which requires the master key.

I'm not sure what your suggested changes here do. Could you please explain it to me step-by-step? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants