Update dependencies and pnpm version #1633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates a number of dependencies used during package development and as part of the build process. In addition to updating dependencies, this commit also updates pnpm to v9.12, which adds the `catalog:` protocol[^1] (it was added in v9.5). The `catalog:` protocol makes it possible to define package versions in `pnpm-workspace.yaml` and use those versions throughout the workspace. This commit moved to `catalog:` for: - eslint - typescript - vite These dependencies are used extensively throughout the workspace, and `catalog:` is an improvement over the implicit `*` dependency we were using for TypeScript. We could make more use of `catalog:` in the future, but this commit focuses on a few dependencies that were updated in multiple places in the workspace as part of the dependency updates in this commit. [^1]: https://pnpm.io/catalogs
pnpm-workspace.yaml
Outdated
| @@ -9,3 +9,7 @@ packages: | |||
| - 'packages/@glimmer-workspace/*' | |||
| - 'packages/@glimmer-workspace/*/test' | |||
| - 'packages/@types/*' | |||
| catalog: | |||
| eslint: ^8.57.1 | |||
| typescript: ^5.6.3 | |||
There was a problem hiding this comment.
I think this has to be on ~5.5 -- ts-eslint doesn't even support 5.6 yet
We're not going to update the rollup plugin in this PR, so we'll stick to TS 5.5 for now. We should move to `@rollup/plugin-typescript` as soon as we can so we don't get stuck on TS 5.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates a number of dependencies used during package development and as part of the build process.
In addition to updating dependencies, this commit also updates pnpm to v9.12, which adds the
catalog:protocol1 (it was added in v9.5).The
catalog:protocol makes it possible to define package versions inpnpm-workspace.yamland use those versions throughout the workspace.This commit moved to
catalog:for:These dependencies are used extensively throughout the workspace, and
catalog:is an improvement over the implicit*dependency we were using for TypeScript.We could make more use of
catalog:in the future, but this commit focuses on a few dependencies that were updated in multiple places in the workspace as part of the dependency updates in this commit.Footnotes
https://pnpm.io/catalogs ↩