Have the benchmark code use the same fake-publish process as the linking script #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
have-the-benchmark-code-use-the-same-fake-publish-process-as-the-linking
branch
from
71a867c
to
15ad763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpm link:alldid a fake publish and made a separate monorepo with all thepublishConfigs resolved.Using that script (extracted to its own script), allows us to simplify the benchmark:setup script a bit.
NOTE: there is a fix for
@glimmer/destroyablethat's needed and this is why theCONTROLversion of the benchmark is erroring.Relies on: #1543