Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] simplify few opcodes #1519

Closed
wants to merge 1 commit into from

Conversation

lifeart
Copy link
Contributor

@lifeart lifeart commented Dec 5, 2023

No description provided.


if (!isConstRef(reference)) {
vm.updateWith(new Assert(reference));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we could remove this part for prod builds at all

@NullVoxPopuli
Copy link
Contributor

This one def wants to wait on #1501

@lifeart lifeart force-pushed the chore-simplify-few-opcodes branch 2 times, most recently from ded1278 to a38673b Compare December 23, 2023 13:37
@lifeart
Copy link
Contributor Author

lifeart commented Dec 23, 2023

image
    Benchmark Results Summary    

duration phase no difference [-114ms to 99ms]
renderEnd phase no difference [0ms to 3ms]
render1000Items1End phase estimated regression +24ms [15ms to 36ms] OR +1.94% [1.22% to 2.85%]
clearItems1End phase no difference [-3ms to 0ms]
render1000Items2End phase no difference [-7ms to 11ms]
clearItems2End phase no difference [-1ms to 0ms]
render5000Items1End phase no difference [-49ms to 24ms]
clearManyItems1End phase no difference [-1ms to 3ms]
render5000Items2End phase no difference [-17ms to 24ms]
clearManyItems2End phase no difference [-3ms to 1ms]
render1000Items3End phase no difference [-2ms to 5ms]
append1000Items1End phase estimated regression +4ms [0ms to 16ms] OR +0.46% [0.02% to 1.74%]
append1000Items2End phase estimated regression +7ms [0ms to 16ms] OR +0.68% [0.01% to 1.71%]
updateEvery10thItem1End phase no difference [-1ms to 1ms]
updateEvery10thItem2End phase no difference [0ms to 0ms]
selectFirstRow1End phase no difference [0ms to 1ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [0ms to 2ms]
removeSecondRow1End phase no difference [-1ms to 1ms]
swapRows1End phase no difference [-2ms to 2ms]
swapRows2End phase no difference [-6ms to 0ms]
clearItems4End phase no difference [-4ms to 2ms]
paint phase no difference [0ms to 0ms]

artifact-1.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants