fix select issue

glimmerjs · Dec 27, 2023 · b88494d · b88494d
1 parent b0821b0
commit b88494d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/benchmark/benchmarks/krausest/lib/components/RowComponent.ts b/benchmark/benchmarks/krausest/lib/components/RowComponent.ts
@@ -4,7 +4,7 @@ import type { Application } from '@/components/Application';
 import { TagComponent } from '@/components/TagComponent';
 import { targetFor, type ComponentRenderTarget, type Destructors } from '@/utils/component';
 import type { Item } from '@/utils/data';
-import { Cell, cellFor, formula } from '@/utils/reactive';
+import { cellFor, formula } from '@/utils/reactive';
 // import { maybeUpdatingPropertyOpcode } from "@/utils/vm";
 
 export function RowComponent(
@@ -38,7 +38,7 @@ export function RowComponent(
       name: 'tr',
       className: formula(() => {
         return id === selectedCell.value ? 'danger' : '';
-      }),
+      }, 'className'),
       // events: {
       //   mouseenter: onMouseEnter,
       //   mouseleave: onMouseLeave,

diff --git a/benchmark/benchmarks/krausest/lib/components/TagComponent.ts b/benchmark/benchmarks/krausest/lib/components/TagComponent.ts
@@ -43,11 +43,11 @@ export function TagComponent(
 
   const slotNode = slot || document.createTextNode('');
 
-  if (typeof className !== undefined) {
+  if (className !== undefined) {
     maybeUpdatingPropertyOpcode(destructors, element, 'className', className);
   }
 
-  if (typeof text !== undefined) {
+  if (text !== undefined) {
     maybeUpdatingPropertyOpcode(destructors, slotNode, 'textContent', text);
   }
 

diff --git a/benchmark/benchmarks/krausest/lib/utils/reactive.ts b/benchmark/benchmarks/krausest/lib/utils/reactive.ts
@@ -87,7 +87,7 @@ export class MergedCell {
     if (this.isConst) {
       return this.fn();
     }
-    if (null === currentTracker && !_isRendering) {
+    if (null === currentTracker && _isRendering) {
       currentTracker = tracker();
       try {
         return this.fn();
@@ -139,6 +139,6 @@ export function cellFor<T extends object, K extends keyof T>(obj: T, key: K): Ce
   return cellValue;
 }
 
-export function formula(fn: () => unknown) {
-  return new MergedCell(fn, 'formula');
+export function formula(fn: () => unknown, debugName?: string) {
+  return new MergedCell(fn, `formula:${debugName ?? 'unknown'}`);
 }