Added prettier-plugin for formatting glimmer component templates #117
Conversation
wondersloth
force-pushed
the
prettier
branch
2 times, most recently
from
6496f59
to
5ab013f
Compare
This comment has been minimized.
This comment has been minimized.
| "prepublishOnly": "scripts/build.js", | ||
| "problems": "tsc -p tsconfig.json --noEmit", | ||
| "start": "webpack-dev-server", | ||
| "storybook": "yarn build && yarn workspace basic-example-app storybook", | ||
| "test": "yarn lint && testem ci && yarn test:babel-plugins", | ||
| "test": "yarn format:check && yarn lint && testem ci && yarn test:babel-plugins && yarn test:prettier", |
There was a problem hiding this comment.
We may not want this here.
There was a problem hiding this comment.
I respond to this in a comment by @chiragpat below.
This comment has been minimized.
This comment has been minimized.
| @@ -13,15 +13,17 @@ | |||
| ], | |||
| "scripts": { | |||
| "build": "scripts/build.js", | |||
| "format:check": "prettier --check 'packages/**/*.{js,ts}'", | |||
There was a problem hiding this comment.
shouldn't this just be done by the prettier plugin in eslint?
There was a problem hiding this comment.
When prettier and eslint both do formatting we get sometimes a double rewrite of a file, with the collision of rules being applied to a tagged template expression.
What we're doing now is simply using prettier to do a style-check format and do a check then use eslint lint for anti-patterns.
| node.type === 'TaggedTemplateExpression' && | ||
| node.tag.type === 'Identifier' && | ||
| node.tag.name === 'hbs' && | ||
| name === 'quasi' |
There was a problem hiding this comment.
This doesn't cover any renames of the named hbs import.
There was a problem hiding this comment.
I will create an issue for this.
There was a problem hiding this comment.
Issue created: #121
hbstagged template expressions with prettier's glimmer printer.2.3.1