Improve Performance in Row Grouping #924
Open
+156
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a performance bottleneck when using the row grouping feature. It is noticeable with a large number of rows and about >~20 groups or so.
Profiler showed that the call to
mapRowIndexToPath
during row height resolution takes most of the time, and it gets slower scrolling towards the end of the list.rowIndex
property was added to identify the exact position of the group in the list. This allowed to create a map that then could be looked up to identify whether the row is a group row or not and resolve the height accordingly, avoiding the expensive call tomapRowIndexToPath
.For further performance improvements, with
rowIndex
property functions likerowNumberMapperOut
andmapRowIndexToPath
could be changed to do a binary search, becausemapRowIndexToPath
can be used asmapper
function in thegetCellContent
consumer code.scrolling profiler recordings:
before change
after
related to #823