-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to manylinux_2_28 #2
Bump to manylinux_2_28 #2
Conversation
05fa9e8
to
9d4d369
Compare
Successfully tested one of the manylinux artifacts on Ubuntu 20.04 with Python 3.8. Creating a virtual environment, installed the wheel followed by omero-py, connected to a server and ran a few queries. Note that right after creating the virtual environment, the wheel package was reported as unsupported
Running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we want to update the warning in the README as part of this PR. Otherwise, let's get this released
@sbesson: Can you check that an upgrade to 20.03 is sufficient and I'll document that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, 20.3 seems to be the minimal pip requirement to install wheel packages using the latest manylinux
platform tags
omero@ngff:/tmp$ python3 -mvenv venv
omero@ngff:/tmp$ venv/bin/pip --version
pip 20.0.2 from /tmp/venv/lib/python3.8/site-packages/pip (python 3.8)
omero@ngff:/tmp$ venv/bin/pip install ~/zeroc_ice-3.6.5-cp38-cp38-manylinux_2_28_x86_64.whl
ERROR: zeroc_ice-3.6.5-cp38-cp38-manylinux_2_28_x86_64.whl is not a supported wheel on this platform.
omero@ngff:/tmp$ venv/bin/pip install -U "pip<20.3"
Collecting pip<20.3
Downloading pip-20.2.4-py2.py3-none-any.whl (1.5 MB)
|████████████████████████████████| 1.5 MB 21.7 MB/s
Installing collected packages: pip
Attempting uninstall: pip
Found existing installation: pip 20.0.2
Uninstalling pip-20.0.2:
Successfully uninstalled pip-20.0.2
Successfully installed pip-20.2.4
omero@ngff:/tmp$ venv/bin/pip install ~/zeroc_ice-3.6.5-cp38-cp38-manylinux_2_28_x86_64.whl
ERROR: zeroc_ice-3.6.5-cp38-cp38-manylinux_2_28_x86_64.whl is not a supported wheel on this platform.
omero@ngff:/tmp$ venv/bin/pip install "pip==20.3"
Collecting pip==20.3
Downloading pip-20.3-py2.py3-none-any.whl (1.5 MB)
|████████████████████████████████| 1.5 MB 22.4 MB/s
Installing collected packages: pip
Attempting uninstall: pip
Found existing installation: pip 20.2.4
Uninstalling pip-20.2.4:
Successfully uninstalled pip-20.2.4
Successfully installed pip-20.3
omero@ngff:/tmp$ venv/bin/pip install ~/zeroc_ice-3.6.5-cp38-cp38-manylinux_2_28_x86_64.whl
Processing /opt/omero/zeroc_ice-3.6.5-cp38-cp38-manylinux_2_28_x86_64.whl
Installing collected packages: zeroc-ice
Successfully installed zeroc-ice-3.6.5
Can also confirm that the cp310 artifact is working nicely on my Ubuntu 22.04 system. |
Switch from manylinux2014 (CentOS 7) to manylinux_2_28 (AlmaLinux 8).
See: