Log session when session unpickling fails #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-allan
requested changes
Jun 11, 2024
| @@ -154,9 +158,13 @@ private void deserializeConnector(Iterator<Op> opIterator) { | |||
| case "is_public": | |||
| isPublic = deserializeBooleanField(opIterator); | |||
| break; | |||
| default: | |||
| log.warn("Unexpected field name in connector: " | |||
There was a problem hiding this comment.
Use parameterized logging:
| } | ||
| } catch (Exception e) { | ||
| log.error("Exception while deserializing: {}", fieldName); | ||
| log.error("Pickled Session: " + b64Session); |
There was a problem hiding this comment.
As above.
Also, I would assume we would rather want to surround the init() in the constructor with a try block and log this at ERROR level if an exception is thrown there, no?
src/test/java/com/glencoesoftware/omero/ms/core/PickledSessionConnectorTest.java
Show resolved
Hide resolved
src/test/java/com/glencoesoftware/omero/ms/core/PickledSessionConnectorTest.java
Show resolved
Hide resolved
sbesson
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
@chris-allan could you check the last commits address your requested changes? As we will likely cut a new patch release of omero-ms-core, this might be a good opportunity to include these changes so that we have additional logging next time the session unpickling fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, to debug an "unpickling" error, we had to dig through Redis to find the session which had created the error. With these changes, exceptions thrown during the unpickling process are caught and the failing session is logged. We also added some logic to give more useful errors in the case where a
BINGETrequests a memoized item which is not present in thememoobject.