Decode Images Without ByteBuffers
#5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This skips one-half of the `ByteBuffer` dance that we currently have to do to get JXR data to C++ and the decoded image bytes back to Java. Currently, this requires manual edits to the SWIG generated Java and C++ files, so this commit also checks these in. As soon as we can re-write the SWIG interface file, we should be able to re-exclude these files.
This method is what the Java wrapper will call in order to return a `byte[]` for the decoded image directly (i.e. without the need for a pre-allocated `ByteStream`).
This is just a simple little change that allows for the testing/validation of returning a `vector<unsigned char>` directly upon decoding an image.
This moves the existing decode assertion utilizing a `ByteBuffer` to `assertBufferDecode` and adds a new `assertByteArrayDecode` method that utilizes the method of directly returning a `byte[]` from image decoding.
|
Closing as discussed in the context of upcoming work on #32. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this branch/PR is to figure out how to avoid having to create direct allocated
ByteBufferobjects (which don't play nice with the JVM's GC) in order to get JXR-encoded data to the underlying C++ library or the decoded pixels back to JVM-land.