-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Google Cloud Storage #176
base: master
Are you sure you want to change the base?
Conversation
@perlman: did you have more work planned here? |
I've been using this unmodified for a while now. I'll bring it up-to-date with main and see where we're at. |
Thanks for the update, @perlman. I'm fine with taking this out of draft status, but adding a usage example to the README would be helpful for testing. |
@perlman, is there a simple example of how to use this feature? |
Whoops, I let this slip. I'll get to this today or tomorrow! (or Monday, sorry about that.) |
@melissalinkert I'm wondering where the right place to put an example. I had started to modify the The usage is very straight forward, e.g.:
That's it. The access credentials will come from the environment, e.g, The credentials must allow for read/write on the bucket. (Minimally, this can be
|
Sorry for dropping this - really was just thinking a few lines in the |
@perlman: that's great, thanks. Do you want to take this out of draft so we can consider for 0.8.0? Or did you have more work planned before this is ready for review? |
I think this meets MVP! I've been using it to convert a bunch of NDPI files to Zarr. At minimum, I think we should add an example of using s3 to the README (& the suggested flags used for Cloudian deployments). "Nice to have" would be working flags for GCS (which require correct value types) and a test using |
This is a small experiment for writing output directly to GCS.
This is done by including google-cloud-nio.
outputOptions
needs to be non-null fornewFileSystem()
.While functional, this is still incomplete:
outputOptions
need to be coerced into Integer/Boolean/etc to work with java-storage-nio.com.google.cloud.storage.contrib.nio.testing
(As a side note, we tried using Google's S3 interface. It fails on a permissions check in JZarr before writing data.)