Enable colorization using the script command.

More info at actions/runner#241 (comment)
gleitz · Apr 20, 2022 · bdcb62f · bdcb62f
1 parent e4d401f
commit bdcb62f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/.github/workflows/python-non-master.yml b/.github/workflows/python-non-master.yml
@@ -35,5 +35,6 @@ jobs:
       run: |
         pylint howdoi *.py --rcfile=.pylintrc
     - name: Test with nose
-      run: |
-        nose2
+      if: runner.os == 'Linux'
+      shell: 'script -q -e -c "bash {0}"'
+      run: nose2
diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml
@@ -31,5 +31,6 @@ jobs:
       run: |
         pylint howdoi *.py --rcfile=.pylintrc
     - name: Test with nose
-      run: |
-        nose2
+      if: runner.os == 'Linux'
+      shell: 'script -q -e -c "bash {0}"'
+      run: nose2
diff --git a/test_howdoi.py b/test_howdoi.py
@@ -196,11 +196,8 @@ def test_colorize(self):
         normal = howdoi.howdoi(query)
         colorized = howdoi.howdoi('-c ' + query)
 
-        # There is currently an issue with Github actions and colorization
-        # so do not run checks if we are running in Github
-        if "GITHUB_ACTION" not in os.environ:
-            self.assertTrue(normal.find('[38;') == -1)
-            self.assertTrue(colorized.find('[38;') != -1)
+        self.assertTrue(normal.find('[38;') == -1)
+        self.assertTrue(colorized.find('[38;') != -1)
 
     # pylint: disable=line-too-long
     def test_get_text_without_links(self):