Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add split function to gleam/bit_array #571

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renatillas
Copy link

@renatillas renatillas commented Apr 25, 2024

Split function for the bit_array package

@renatillas
Copy link
Author

renatillas commented Apr 25, 2024

NOTE: This still lacks the javascript target
The Javascript target has been implemented to match the Erlang one.

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! We'll need a JavaScript implementation too

@renatillas
Copy link
Author

renatillas commented Apr 25, 2024

I'm having trouble working with the gleam_stdlib.mjs as it cannot import gleam.mjs as it's missing. How I'm supposed to get it?

@renatillas renatillas changed the title Add slice function to gleam/bit_array Add split function to gleam/bit_array Apr 25, 2024
@lpil
Copy link
Member

lpil commented Apr 25, 2024

Could you expand on that a little please? You import it like any other file.

@renatillas
Copy link
Author

src/gleam_stdlib.mjs |12 col 8-21 error| Unable to load a local module: file:///Users/renata-amutio/Projects/renatillas/stdlib/src/gleam.mjs Please check the file path.

While working on the gleam_stdlib.mjs there's a dependency to ./gleam.mjs but the file is missing in the repository. What am I missing?

@renatillas
Copy link
Author

Also

meme_array_split

@renatillas renatillas marked this pull request as ready for review April 25, 2024 19:22
@renatillas renatillas requested a review from lpil April 25, 2024 19:23
@lpil
Copy link
Member

lpil commented Apr 26, 2024

./gleam.mjs is the Gleam prelude, it is rendered by the build tool during project compilation.

@lpil
Copy link
Member

lpil commented May 20, 2024

Closing due to inactivity. Please feel free to reopen! Thank you

@lpil lpil closed this May 20, 2024
@renatillas
Copy link
Author

renatillas commented May 25, 2024

Hi! The PR is ready for review as the implementation is completed with some tests and documentation. Is something missing? In the case we feel this should be reopened, should I create a new PR or can it be done on the same PR?

Thank you!

@lpil lpil reopened this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants