gh-385: set random seeds in all glass functions used in notebooks #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leverage the `rng` input to all functions in `glass` so that the notebook figures should always be the same when run again.
paddyroddy
added
enhancement
Saransh-cpp
reviewed
Nov 5, 2024
Saransh-cpp
approved these changes
Nov 5, 2024
|
@ntessore can you have a look? |
ntessore
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Great effort to make the outputs more stable. There's one notebook that doesn't do any sampling, but still gets a rng.
In a separate change, we probably want to add a matplotlibrc or similar to control at least the resolution of the notebook figures – you can see here that the images still depend on who generated them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #385.
Leverage the
rnginput to all functions inglassso that the notebook figures should always be the same when run again.Also add https://github.com/kynan/nbstripout with
--keep-outputwhich will clear the metadata of the notebooks but make sure figures are still shown.Have tested this by running the notebooks in full and running
pre-commit, and committing. Then executing in full again and runningpre-commitand checking if anything changed - which it hadn't.