gh-185: update CONTRIBUTING.md (developer guide) #255
Conversation
Saransh-cpp
force-pushed
the
saransh/developer-guide
branch
from
36c8a10
to
eb7586c
Compare
CONTRIBUTING.md
Outdated
| following way - | ||
|
|
||
| ```bash | ||
| python -m pytest --cov=glass --doctest-plus -v |
There was a problem hiding this comment.
For another PR, but we can configure the coverage in pyproject.toml so one doesn't need to explicitly write --cov=glass. https://github.com/astro-informatics/sleplet/blob/782279ec1be404aa356c6e0b583bd536cf3a4789/pyproject.toml#L101-L109
There was a problem hiding this comment.
Added -v in the recent PR. I usually avoid adding the cov and the doctest-plus option in pyproject.toml because we don't need those always.
There was a problem hiding this comment.
I agree, my suggestion is you add to it the coverage section. So when you ask for coverage you get it on glass without having to specify it - I'm not asking for the pytest section
There was a problem hiding this comment.
Ahh, let me quickly check that.
There was a problem hiding this comment.
Don't worry we can fix in another issue #282
Saransh-cpp
force-pushed
the
saransh/developer-guide
branch
from
e655959
to
de49684
Compare
Saransh-cpp
force-pushed
the
saransh/developer-guide
branch
from
de49684
to
c113d3c
Compare
I have updated the contributing guideline to reflect all the recent changes. I think keeping it just on GitHub should be okay, given that the new developers will look at the GitHub repository before contributing.
Closes: #185