Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-204: examples run twice on PRs #242

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

Saransh-cpp
Copy link
Member

Minor fix. The examples run twice on PRs right now as branches is not specified under on.

Refs: #204

@Saransh-cpp Saransh-cpp added the infrastructure Project infrastructure: dev tools, packaging, etc. label Sep 18, 2024
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

.github/workflows/examples.yml Outdated Show resolved Hide resolved
Saransh-cpp and others added 3 commits September 18, 2024 16:40
Minor fix. The examples run twice on PRs right now as `branches` is not specified under `on`.

Refs: #204
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, merging

@paddyroddy paddyroddy merged commit 1b4d5c8 into main Sep 18, 2024
10 checks passed
@paddyroddy paddyroddy deleted the saransh/double-example-runs branch September 18, 2024 16:13
@Saransh-cpp Saransh-cpp self-assigned this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Project infrastructure: dev tools, packaging, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants