-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-176: revamp publishing workflow #209
Conversation
steps: | ||
- uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how checkout
without setting fetch-depth: 0
was working (or maybe it was silently failing)? Given that glass uses VCS for versioning, it becomes important to pull in the entire git history (not a bad thing) to make the versions/tags work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work since it's the release tag itself that is being cloned to a depth of 1 here:
% git clone --branch v2024.1 --depth 1 https://github.com/glass-dev/glass.git glass-v2024.1
% cd glass-v2024.1
% git describe --tags
v2024.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, the workflow is triggered when a release is published so the it checkout
s on the tag and not the branch. That makes sense, thanks!
@@ -1,20 +1,49 @@ | |||
name: Release | |||
|
|||
on: | |||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be manually triggered now to build wheels.
1cba69a
to
0af4a8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there testing files in this PR? Seems unrelated
Ah, I should look at my git history more closely while jumping between branches. Thanks for pointing out! |
0af4a8a
to
8f4b977
Compare
Pull Request Test Coverage Report for Build 10903784563Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 10903784563Details
💛 - Coveralls |
8f4b977
to
98349b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
98349b8
to
01f102c
Compare
01f102c
to
a10699e
Compare
The developers will now be able to download wheels as artifacts from GH Actions without actually publishing a release. This helps in checking if everything is working well or if you want to distribute a pre-release wheel. Anyways, it is a good practice to keep these 2 jobs separate.
Closes: #176
Refs: #187