Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-176: revamp publishing workflow #209

Merged
merged 2 commits into from
Sep 18, 2024
Merged

gh-176: revamp publishing workflow #209

merged 2 commits into from
Sep 18, 2024

Conversation

Saransh-cpp
Copy link
Member

@Saransh-cpp Saransh-cpp commented Sep 13, 2024

The developers will now be able to download wheels as artifacts from GH Actions without actually publishing a release. This helps in checking if everything is working well or if you want to distribute a pre-release wheel. Anyways, it is a good practice to keep these 2 jobs separate.

Closes: #176
Refs: #187

steps:
- uses: actions/checkout@v4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how checkout without setting fetch-depth: 0 was working (or maybe it was silently failing)? Given that glass uses VCS for versioning, it becomes important to pull in the entire git history (not a bad thing) to make the versions/tags work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work since it's the release tag itself that is being cloned to a depth of 1 here:

% git clone --branch v2024.1 --depth 1 https://github.com/glass-dev/glass.git glass-v2024.1
% cd glass-v2024.1 
% git describe --tags
v2024.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, the workflow is triggered when a release is published so the it checkouts on the tag and not the branch. That makes sense, thanks!

@@ -1,20 +1,49 @@
name: Release

on:
workflow_dispatch:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be manually triggered now to build wheels.

@Saransh-cpp Saransh-cpp added the infrastructure Project infrastructure: dev tools, packaging, etc. label Sep 13, 2024
@paddyroddy paddyroddy self-requested a review September 17, 2024 11:32
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there testing files in this PR? Seems unrelated

@Saransh-cpp
Copy link
Member Author

Ah, I should look at my git history more closely while jumping between branches. Thanks for pointing out!

@coveralls
Copy link

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 10903784563

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.256%

Totals Coverage Status
Change from base Build 10883249379: 0.0%
Covered Lines: 458
Relevant Lines: 860

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10903784563

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.256%

Totals Coverage Status
Change from base Build 10883249379: 0.0%
Covered Lines: 458
Relevant Lines: 860

💛 - Coveralls

Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Saransh-cpp Saransh-cpp merged commit 465f72a into main Sep 18, 2024
9 checks passed
@Saransh-cpp Saransh-cpp deleted the saransh/cd branch September 18, 2024 12:49
@Saransh-cpp Saransh-cpp self-assigned this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Project infrastructure: dev tools, packaging, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split the release workflow into 2 jobs - build and publish
4 participants