gh-182: fix citation link on PyPI #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative links don't work as it will try and load https://pypi.org/project/glass/CITATION.md which doesn't exist this fixes it by referring specifically to the file on GitHub
paddyroddy
added
bug
Saransh-cpp
approved these changes
Sep 11, 2024
paddyroddy
changed the title
ntessore
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Could keep the link to the CITATION file, or link to https://glass.readthedocs.io/stable/user/publications.html?
Have changed to publications - seems a bit neater than to GitHub. Will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative links don't work as it will try and load
https://pypi.org/project/glass/CITATION.md which doesn't exist this fixes it by referring specifically to the file on GitHub. Fixes #182.
Reviewed-by: Saransh Chopra [email protected]
Reviewed-by: Nicolas Tessore