Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add backticks to tag #18

Closed
wants to merge 1 commit into from
Closed

Conversation

ruudk
Copy link

@ruudk ruudk commented Oct 5, 2023

We use @todo as tag, and it's annoying that now this tags username todo ;)

We use `@todo` as tag, and it's annoying that now this tags username `todo` ;)
@ruudk
Copy link
Author

ruudk commented Oct 5, 2023

I assume a test will fail, but I cannot see it immediately because the workflow needs to be approved.

@gkampitakis
Copy link
Owner

Hey 👋 thanks for the pr but I am wondering you can't pass the tag with the backticks in the input it doesn't render correctly ?

@ruudk
Copy link
Author

ruudk commented Oct 6, 2023

But then the script will search for `@todo` ?

@gkampitakis
Copy link
Owner

Ahh 💡 I see. Not going to lie haven't looked into this code for a long time 😅 . Wondering if it makes more sense to add the backticks only if the tag contains @ instead of changing everything. Can't recall how it renders.

@ruudk ruudk closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants