add semantic versioning to contracts #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihooni
commented
Nov 3, 2025
Comment on lines
+70
to
+73
| (bool success,) = proxy.staticcall(abi.encodeWithSelector(ISemver.version.selector)); | ||
| if (!success) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
if version() interface is not implemented, needs to upgrade.
Comment on lines
+67
to
+68
| (VmSafe.CallerMode m,,) = vm.readCallers(); | ||
| require(m == VmSafe.CallerMode.None, "Only offchain"); |
There was a problem hiding this comment.
ensure that this function should be simulated, not broadcast.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces semantic versioning to all Dojang contracts using a standardized ISemver interface and version string format. The implementation enables version-aware contract upgrades through an automated upgrade script that checks semantic version differences.
- Added ISemver interface defining a standard version() function returning string
- Updated all contracts to implement semantic versioning with "0.2.0" version
- Created upgrade infrastructure with version comparison logic to prevent unnecessary upgrades
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/interfaces/ISemver.sol | New interface defining semantic versioning standard |
| src/SchemaBook.sol | Added ISemver implementation with version "0.2.0" |
| src/DojangScroll.sol | Added ISemver implementation with version "0.2.0" |
| src/DojangAttesterBook.sol | Added ISemver implementation with version "0.2.0" |
| src/BalanceDojangResolver.sol | Moved version function and updated to semantic versioning |
| src/AttestationIndexer.sol | Added ISemver implementation with version "0.2.0" |
| src/AddressDojangResolver.sol | Moved version function and updated to semantic versioning |
| script/utils/DeployConfig.s.sol | New utility for reading deployment configuration |
| script/upgrade/Upgrade.s.sol | New upgrade script with semantic version comparison |
| package.json | Updated package version to match contract versions |
| foundry.toml | Added filesystem permissions for deploy config |
| deploy-config/91342.json | New deployment configuration for testnet |
| test files | Updated test assertions to match new version strings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jaden-dunamu
approved these changes
Nov 4, 2025
troy-dunamu
approved these changes
Nov 4, 2025
jensendunamu
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces semantic versioning to all Dojang contracts to improve version tracking and maintainability.
Each contract now exposes a
version()function.In addition, upgrade script has been added that performs contracts upgrades only when the semantic version has changed, ensuring cleaner and more intentional upgrade processes.
Related Issue
Closes #5