Fix test skip mechanism to handle empty env vars #21190
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
ifEnvVarNotSetutility to properly skip tests when environment variables are set to empty strings.Problem
The test skip mechanism was failing in CI because:
ifEnvVarNotSetonly checked forundefined"")Example from CI logs:
Solution
Updated
ifEnvVarNotSetto check for bothundefinedand empty strings:This ensures tests are skipped when tokens are missing or empty, preventing spurious CI failures.
Testing
Verified the logic handles all cases correctly:
undefined→ skipRelated
Fixes test failures seen in https://github.com/gitpod-io/gitpod/actions/runs/20091345213/job/57639328696