Skip to content

upgrade golang to 1.24.3 #20846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025
Merged

upgrade golang to 1.24.3 #20846

merged 4 commits into from
May 28, 2025

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented May 26, 2025

Description

upgrade golang to 1.24.3

Related Issue(s)

Fixes CLC-1067

How to test

pass all integration tests then start a workspace in preview env for smoke test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@iQQBot
Copy link
Contributor Author

iQQBot commented May 27, 2025

builds are all green, running integration test now

@iQQBot iQQBot marked this pull request as ready for review May 27, 2025 13:55
@iQQBot
Copy link
Contributor Author

iQQBot commented May 27, 2025

only 1 integration test fail, but I don't think it related, because I can start workspace in this preview env, and others integration tests are good

image

@iQQBot
Copy link
Contributor Author

iQQBot commented May 28, 2025

@geropl I rebase PR to main, and double check the integration test, it seems the integration test is outdated, it using create a user directly in database, and this user without org, this behavior seems outdated. in server code, it always assumed we have organizationId

@iQQBot
Copy link
Contributor Author

iQQBot commented May 28, 2025

image

double check for client hello package

@iQQBot iQQBot requested a review from geropl May 28, 2025 12:56
@iQQBot iQQBot requested review from kylos101 and Copilot May 28, 2025 12:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Go version and toolchain for various Gitpod components to version 1.24.3. It also adds the setting "godebug tlsmlkem=0" to each module, ensuring consistency across the codebase.

  • Upgrade Go language version and toolchain in go.mod files.
  • Introduce "godebug tlsmlkem=0" in all modules.
  • Update dependency versions for a few indirect libraries in selected modules.

Reviewed Changes

Copilot reviewed 98 out of 98 changed files in this pull request and generated 19 comments.

Show a summary per file
File Description
components/ide/code/codehelper/go.mod Updated Go version/toolchain and added godebug flag
components/ide/code-desktop/status/go.mod Updated Go version/toolchain and added godebug flag
components/ide-service/go.mod Updated Go version/toolchain and added godebug flag
components/ide-service-api/go/go.mod Updated Go version/toolchain and added godebug flag
components/ide-metrics/go.mod Updated Go version/toolchain and added godebug flag
components/ide-metrics-api/go/go.mod Updated Go version/toolchain and added godebug flag
components/ide-metrics-api/go.mod Updated Go version/toolchain and added godebug flag
components/gitpod-protocol/go/go.mod Updated Go version/toolchain and added godebug flag
components/gitpod-db/go/go.mod Updated Go version/toolchain and added godebug flag
components/gitpod-cli/go.mod Updated Go version/toolchain and added godebug flag, removed one indirect dependency
components/ee/agent-smith/go.mod Updated Go version/toolchain and added godebug flag
components/ee/agent-smith/cmd/testtarget/go.mod Updated Go version/toolchain and added godebug flag
components/ee/agent-smith/cmd/testbed/go.mod Updated Go version/toolchain and added godebug flag
components/docker-up/go.mod Updated Go version/toolchain and added godebug flag
components/content-service/go.mod Updated Go version/toolchain and added godebug flag
components/content-service-api/typescript/util/go.mod Updated Go version/toolchain, bumped dependency versions, and added godebug flag
components/content-service-api/go/go.mod Updated Go version/toolchain and added godebug flag
components/common-go/go.mod Updated Go version/toolchain and added godebug flag
components/blobserve/go.mod Updated Go version/toolchain, adjusted dependency removal, and added godebug flag

@gitpod-io gitpod-io deleted a comment from Copilot AI May 28, 2025
@gitpod-io gitpod-io deleted a comment from Copilot AI May 28, 2025
@gitpod-io gitpod-io deleted a comment from Copilot AI May 28, 2025
@iQQBot
Copy link
Contributor Author

iQQBot commented May 28, 2025

/unhold

@roboquat roboquat merged commit 301f1b7 into main May 28, 2025
95 of 98 checks passed
@roboquat roboquat deleted the pd/CLC-1067 branch May 28, 2025 17:32
@kylos101
Copy link
Contributor

@iQQBot I see go vet go updated (hence the formatting changes you made): https://tip.golang.org/doc/go1.24#vet

@iQQBot
Copy link
Contributor Author

iQQBot commented May 28, 2025

@iQQBot I see go vet go updated (hence the formatting changes you made): https://tip.golang.org/doc/go1.24#vet

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants