-
Notifications
You must be signed in to change notification settings - Fork 1.3k
upgrade golang to 1.24.3 #20846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade golang to 1.24.3 #20846
Conversation
af49211
to
4b49fbb
Compare
|
builds are all green, running integration test now |
@geropl I rebase PR to main, and double check the integration test, it seems the integration test is outdated, it using create a user directly in database, and this user without org, this behavior seems outdated. in server code, it always assumed we have organizationId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the Go version and toolchain for various Gitpod components to version 1.24.3. It also adds the setting "godebug tlsmlkem=0" to each module, ensuring consistency across the codebase.
- Upgrade Go language version and toolchain in go.mod files.
- Introduce "godebug tlsmlkem=0" in all modules.
- Update dependency versions for a few indirect libraries in selected modules.
Reviewed Changes
Copilot reviewed 98 out of 98 changed files in this pull request and generated 19 comments.
Show a summary per file
File | Description |
---|---|
components/ide/code/codehelper/go.mod | Updated Go version/toolchain and added godebug flag |
components/ide/code-desktop/status/go.mod | Updated Go version/toolchain and added godebug flag |
components/ide-service/go.mod | Updated Go version/toolchain and added godebug flag |
components/ide-service-api/go/go.mod | Updated Go version/toolchain and added godebug flag |
components/ide-metrics/go.mod | Updated Go version/toolchain and added godebug flag |
components/ide-metrics-api/go/go.mod | Updated Go version/toolchain and added godebug flag |
components/ide-metrics-api/go.mod | Updated Go version/toolchain and added godebug flag |
components/gitpod-protocol/go/go.mod | Updated Go version/toolchain and added godebug flag |
components/gitpod-db/go/go.mod | Updated Go version/toolchain and added godebug flag |
components/gitpod-cli/go.mod | Updated Go version/toolchain and added godebug flag, removed one indirect dependency |
components/ee/agent-smith/go.mod | Updated Go version/toolchain and added godebug flag |
components/ee/agent-smith/cmd/testtarget/go.mod | Updated Go version/toolchain and added godebug flag |
components/ee/agent-smith/cmd/testbed/go.mod | Updated Go version/toolchain and added godebug flag |
components/docker-up/go.mod | Updated Go version/toolchain and added godebug flag |
components/content-service/go.mod | Updated Go version/toolchain and added godebug flag |
components/content-service-api/typescript/util/go.mod | Updated Go version/toolchain, bumped dependency versions, and added godebug flag |
components/content-service-api/go/go.mod | Updated Go version/toolchain and added godebug flag |
components/common-go/go.mod | Updated Go version/toolchain and added godebug flag |
components/blobserve/go.mod | Updated Go version/toolchain, adjusted dependency removal, and added godebug flag |
/unhold |
@iQQBot I see go vet go updated (hence the formatting changes you made): https://tip.golang.org/doc/go1.24#vet |
Yes |
Description
upgrade golang to 1.24.3
Related Issue(s)
Fixes CLC-1067
How to test
pass all integration tests then start a workspace in preview env for smoke test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold