[TB] allow to config launcher from Dashboard #20051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustard-mh
commented
Jul 18, 2024
| out: java/src/main/java | ||
| - plugin: buf.build/protocolbuffers/java | ||
| # https://buf.build/protocolbuffers/java?version=v27.2 | ||
| - plugin: buf.build/protocolbuffers/java:v27.2 |
There was a problem hiding this comment.
Pin java plugin's version in case it updates java protobuf version and make lib usages incompatible
mustard-mh
changed the title
mustard-mh
changed the title
mustard-mh
commented
Jul 19, 2024
| @@ -98,6 +99,7 @@ func main() { | |||
| // supervisor refer see https://github.com/gitpod-io/gitpod/blob/main/components/supervisor/pkg/supervisor/supervisor.go#L961 | |||
| shouldWaitBackendPlugin := os.Getenv("GITPOD_WAIT_IDE_BACKEND") == "true" | |||
| debugEnabled := os.Getenv("SUPERVISOR_DEBUG_ENABLE") == "true" | |||
| preferToolbox := os.Getenv("GITPOD_PREFER_TOOLBOX") == "true" | |||
There was a problem hiding this comment.
We have to use env so that we don't need to rebuild all versions of all JetBrains IDEs (args to start launcher are written inside image)
mustard-mh
commented
Jul 19, 2024
| "phpstorm" | ||
| ], | ||
| "installationSteps": [ | ||
| "If you don't see an open dialog in your browser, make sure you have the \u003ca target='_blank' class='gp-link' href='https://www.gitpod.io/docs/ides-and-editors/jetbrains-gateway#getting-started-jetbrains-gateway'\u003eJetBrains Toolbox with Gitpod Plugin\u003c/a\u003e installed on your machine, and then click \u003cb\u003e${OPEN_LINK_LABEL}\u003c/b\u003e below." |
There was a problem hiding this comment.
Draft changes, will update in the future
filiptronicek
approved these changes
Jul 19, 2024
| @@ -25,18 +27,21 @@ export default function SelectIDE(props: SelectIDEProps) { | |||
|
|
|||
| const [defaultIde, setDefaultIde] = useState<string>(user?.editorSettings?.name || "code"); | |||
| const [useLatestVersion, setUseLatestVersion] = useState<boolean>(user?.editorSettings?.version === "latest"); | |||
| const [preferToolbox, setPreferToolbox] = useState<boolean>(user?.editorSettings?.preferToolbox || false); | |||
There was a problem hiding this comment.
nit: we can only default on undefined
Suggested change
| const [preferToolbox, setPreferToolbox] = useState<boolean>(user?.editorSettings?.preferToolbox || false); | |
| const [preferToolbox, setPreferToolbox] = useState<boolean>(user?.editorSettings?.preferToolbox ?? false); |
| @@ -46,9 +51,10 @@ export default function SelectIDE(props: SelectIDEProps) { | |||
| additionalData: { | |||
| workspaceAutostartOptions, | |||
| ideSettings: { | |||
| settingVersion: "2.0", | |||
| settingVersion: IDESettingsVersion, | |||
|
Thank you @filiptronicek |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes ENT-442
How to test
enable_experimental_jbtbeverything should work like beforeDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold