Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unknown refs instead of throwing an exception #161

Merged
merged 4 commits into from
Jan 7, 2020
Merged

Ignore unknown refs instead of throwing an exception #161

merged 4 commits into from
Jan 7, 2020

Conversation

juanmcasanova
Copy link
Contributor

Solves #160

@GrahamCampbell
Copy link
Member

GrahamCampbell commented Jan 3, 2020

Thanks. Could you add a test covering an example gitlab ref that would have caused an exception?

@juanmcasanova
Copy link
Contributor Author

Done!

@alexandresalome
Copy link
Member

I love it when deleting code solves problems :)

@juanmcasanova
Copy link
Contributor Author

Travis errors should be fixed now

@phpfui
Copy link
Contributor

phpfui commented Jan 4, 2020

Would love to see a new release of this library. I am doing a documentation package that uses the markup files in the docs. The problem is I am validating the html, and there is an error with the md files (someone put in a tag). But I have already submitted a PR (Approved!) to fix this, except it was not stamped as a new version, since it was only a doc change (completely understandable).

Anyway, my unit tests are failing since I want to be a stable version (as going with dev stability introduces other issues).

So long story short, I would really appreciate a new release once this PR merges. Thanks for continuing to maintain this repo, looks like the best one out there!

@GrahamCampbell GrahamCampbell merged commit 169a1d2 into gitonomy:master Jan 7, 2020
@GrahamCampbell
Copy link
Member

Thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants