Repository navigation
Conversation
The migration from the v6 unified `gitify-storage` key to the split Zustand stores has shipped since v7.0.0. Removing it ahead of the next major release, which no longer supports upgrading directly from v6.
|
setchy
changed the title
setchy
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
migrateLegacyStoreToZustand(), the one-shot migration from the v6 unifiedgitify-storagelocalStorage key to the split Zustand stores introduced in v7.0.0.The TODO on the function asked for removal in a future major release, and this lands ahead of the next major, which no longer supports upgrading directly from v6.
Changes
src/renderer/utils/core/storage.tsandstorage.test.tssrc/renderer/App.tsxConstants.STORAGE.LEGACY(gitify-storage) fromsrc/renderer/constants.tsBehaviour change
Users upgrading v6 → v8 directly will no longer have their legacy accounts and settings migrated: they will land on the login screen with default settings, and the old
gitify-storagekey will remain in localStorage. Users who have run any 7.x release are unaffected, since the migration already consumed and removed that key.Upgrading via 7.x is the supported path. Worth calling out in the v8 release notes.
Validation
pnpm check— clean (lint, format, type-check)pnpm test— 203 files / 1967 tests passing