Repository navigation
Conversation
github-actions
Bot
added
the
enhancement
setchy
force-pushed
the
feat/actionable-native-alerts
branch
from
October 24, 2026 17:55
9e98192 to
1d9bff5
Compare
setchy
force-pushed
the
feat/actionable-native-alerts
branch
2 times, most recently
from
October 24, 2026 19:40
71713bf to
43e64db
Compare
setchy
force-pushed
the
feat/actionable-native-alerts
branch
2 times, most recently
from
October 24, 2026 21:31
23adf0f to
f133fb0
Compare
setchy
force-pushed
the
feat/actionable-native-alerts
branch
from
October 25, 2026 02:36
f133fb0 to
211f7ae
Compare
setchy
changed the base branch from
main
to
refactor/settings-controls-primer
October 25, 2026 02:36
setchy
force-pushed
the
feat/actionable-native-alerts
branch
3 times, most recently
from
October 25, 2026 03:32
34c218b to
f698481
Compare
setchy
force-pushed
the
feat/actionable-native-alerts
branch
3 times, most recently
from
October 25, 2026 11:49
b865812 to
a32756f
Compare
Move OS notifications into a main-process service behind typed IPC, with native actions, grouping, and list anchoring. Keep focus scrolling animated and make the browser tests wait for the scroll to settle. Address the Sonar findings on identifier validation, optional chaining, stable string sorting, and the intentionally sequential native publish loop.
setchy
force-pushed
the
feat/actionable-native-alerts
branch
from
October 25, 2026 11:49
a32756f to
0448183
Compare
Resolve conflicts from the settings-controls and visual-regression refactors: - Keep main's shared createGitifyBridgeApi helper and move the native notifications bridge mock into it - Keep both NotificationRow attributes: focus tracking and exit animation - Merge AlertSettings tests: main's control conventions plus the native notification style, actions, and click coverage - Take the native notification test suite; main's tests covered the removed preload API - Accept main's deletion of the Settings route snapshot - Refresh the notification-volume visual baselines for the new Alerts rows
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SettingsChoice/SettingsTogglewrappers.pnpm sign:devso macOS development builds can deliver native notifications.Native notification behavior
macOS note: since macOS 11, the system places all notification actions behind the hover-only Options menu. There is no public API to restore the old inline primary button, so the action set is kept small and body click is the open affordance.
Verification
pnpm test: 204 files, 2,046 tests passedpnpm exec vp check --no-fmt: 474 files passedscripts/visual.sh settings: 9 baselines passedscripts/visual.sh filters: 2 baselines passedManual checks still pending
Info.plistverification and signed action/click/removal checks