Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show "read" notifications #1052

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

setchy
Copy link
Member

@setchy setchy commented Apr 19, 2024

Closes #708

Add new Notification Settings to show all notifications (defaulted to off).

When set, notification rows will be opaque when read.

The mark as read button both at the Repository and Notification level are conditional based on whether the notification(s) are unread or not.

Some things to note

  1. we don't support fetching more than the first page of REST API results, so the notifications will be maxed at 50
  2. the API returns all notifications (unread, read, done)

Screenshot 2024-04-20 at 7 10 57 AM
Screenshot 2024-04-20 at 7 11 06 AM
Screenshot 2024-04-20 at 7 11 19 AM

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Apr 19, 2024
@setchy setchy added this to the Release 5.5.0 milestone Apr 19, 2024
@setchy setchy changed the title feat: show read notifications feat: show all notifications Apr 20, 2024
@setchy
Copy link
Member Author

setchy commented Apr 20, 2024

TODO - need to find a solution to recalculate the unread notification count

@setchy setchy removed this from the Release 5.5.0 milestone May 1, 2024
@setchy setchy added the blocked Is blocked by another issue or dependency label Jun 17, 2024
@setchy setchy changed the title feat: show all notifications feat: show "read" notifications Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Is blocked by another issue or dependency enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: add a "Show read notifications" setting
1 participant