Primer branding: reduce ultra-heavy heading font weights - #181
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
There was a problem hiding this comment.
Reviewer kind: ponytail (CSS-only styling change)
No blocking issues. This is a minimal, low-risk change reducing font-weight: 800 → 700 on four heading/eyebrow selectors (.site-header h1, .recipe-key, .copy-modal-eyebrow, .landing-title) for Primer brand alignment. No markup or logic changes; visual hierarchy is preserved since all four rules were changed consistently. Tests and build reportedly pass. Nothing to request changes on.
Generated by Specialist PR Review for #181 · auto · 12.6 AIC · ⌖ 1.67 AIC · ⊞ 7.9K
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Typography
font-weight: 800tofont-weight: 700on four heading/eyebrow rules insrc/styles/style.css:.site-header h1,.recipe-key,.copy-modal-eyebrow, and.landing-title.primer_brand_review) flagged these asheavy-font-weightfindings — "Ultra-heavy/black weights are off-brand. Favour regular and medium, with bold for genuine emphasis."700(bold) is the appropriate ceiling per that guidance, while preserving the existing visual hierarchy (headline vs. body).Audit findings not changed (and why)
var(--color-*, #hexFallback)pattern (e.g.--accent-blue: var(--color-accent-fg, #0969da)), which is the correct Primer approach — colors resolve to Primer CSS variables at runtime, with the hex values serving only as fallbacks matching those same tokens. Theprimer_brand_reviewtool'shardcoded-hexwarning is a blanket regex match on hex literals and doesn't distinguish token fallbacks from true hardcoded colors, so no changes were made here.--title-gradient-*and--accent-blue/--accent-greengradients used in.site-header h1and.landing-titleall resolve through existing Primer color tokens (--color-accent-fg,--color-done-emphasis,--color-sponsors-emphasis) in one aligned color family and were left as tasteful, on-brand accents per the task's gradient guidance.styled-headingwarning: "Use theHeadingcomponent for type styles"): this is a plain static HTML/Vite site with no@primer/react-branddependency installed — introducing React Brand components here would require adding a new runtime dependency and restructuring markup, both out of scope per the task rules ("Do NOT add new runtime dependencies", "Do NOT restructure the page"). Left as a follow-up if the project ever migrates to React.style.css; the few remaining rawpxvalues (1px/2px/5px/8px, used for hairline borders and small offsets) are below the threshold where Primer spacing tokens apply and are standard practice for border/shadow precision, so left unchanged.Validation
npm test— 205 tests passed (13 test files)npm run build— production build succeededChange set is intentionally small and low-risk: one CSS property value change repeated across four selectors, no markup or logic changes.