feat: add host.docker.internal support #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable `host.docker.internal` DNS name in the agent container by adding `extra_hosts: ['host.docker.internal:host-gateway']` to the Docker Compose configuration. This provides a cross-platform way to connect from inside the firewall to services running on the host machine, which is particularly useful for MCP servers running on the host. - Add extra_hosts configuration to agent service in docker-manager.ts - Add extra_hosts property to DockerService type in types.ts - Add test to verify extra_hosts configuration is generated correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...] |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Test Coverage Report
Coverage ThresholdsThe project has the following coverage thresholds configured:
Coverage report generated by `npm run test:coverage` |
Smoke Test Results (run #20469760133)Last 2 merged PRs:
Test Results:
Status: PASS
|
Smoke Test Results (Claude)Last 2 Merged PRs:
Test Results:
Status: FAIL (Playwright unable to load page resources)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
host.docker.internalDNS name in the agent container for cross-platform container-to-host communicationextra_hosts: ['host.docker.internal:host-gateway']to Docker Compose configurationBackground
host.docker.internalis a special DNS name that resolves to the host machine's IP address from inside a container:extra_hostsconfigPreviously, users on Linux had to use the gateway IP (
172.30.0.1) directly. With this change, both approaches work:http://host.docker.internal:8080/mcp/gh-awhttp://172.30.0.1:8080/mcp/gh-awChanges
src/docker-manager.ts: Addextra_hoststo agent service configsrc/types.ts: Addextra_hostsproperty toDockerServiceinterfacesrc/docker-manager.test.ts: Add test forextra_hostsconfigurationTest plan
npm test -- --testPathPattern="docker-manager")host.docker.internal🤖 Generated with Claude Code