refactor: reduce complexity of execute_impl in upload_build_attachment.rs

[github-actions]

Summary

Clippy's too_many_lines lint flagged UploadBuildAttachmentResult::execute_impl at 267/100 lines — the highest-complexity function in src/safe_outputs/ not already addressed in a prior refactor pass (per cache-memory history: create_pull_request.rs::execute_impl at 349/100 was already tackled across two prior PRs and remains the single largest outlier, but two other executors — this one and upload_workitem_attachment.rs — were the next biggest and this one was still unaddressed).

The function mixed together: build-id resolution/validation, artifact-name prefixing and allow-list checks, extension allow-list checks, attachment-type validation, staged-file path/size/directory verification, SHA-256 integrity checking, ADO context resolution (org/project/token/plan/timeline/record), URL construction, and the actual HTTP PUT + response handling — all inline in one async fn.

Changes

Extracted the following helpers (all private, no public API changes):

• resolve_effective_build_id — resolves/validates the current-run build id against the agent-supplied build_id
• resolve_final_artifact_name — applies name-prefix and validates charset/length/allow-list
• check_extension_allowed — validates the file extension against allowed-extensions
• resolve_attachment_type (free fn) — resolves/validates the attachment-type config value
• resolve_and_verify_staged_file — canonicalizes the staged path, verifies it's within the working directory, isn't a directory, and matches the recorded size/max-size
• resolve_ado_upload_context (free fn) — resolves org URL, project, token, project id, plan id, timeline id, record id from ExecutionContext
• build_attachment_url (free fn) — builds the DistributedTask timeline-attachment URL
• upload_attachment — sends the PUT request and maps the response to an ExecutionResult

execute_impl itself is now a short, linear sequence of calls to these helpers, unwrapping the Result<T, ExecutionResult> pattern used throughout the codebase for validation short-circuits.

Verification

• cargo build — clean
• cargo test — 3118 tests pass (including all 42 upload_build_attachment tests), 0 failures
• cargo clippy --all-targets --all-features — clean
• Re-ran the too_many_lines clippy check scoped to this file: the lint no longer fires for execute_impl

No behavior or public API changes — this is a pure internal restructuring for readability/testability.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• spsprodeus21.vssps.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "spsprodeus21.vssps.visualstudio.com"

See Network Configuration for more information.

Generated by Cyclomatic Complexity Reducer · auto · 106.6 AIC · ⌖ 8.12 AIC · ⊞ 11.3K · ◷

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.