Add permissions to workflow #567
Conversation
Bundle Stats — With chunk and module informationHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed
Bigger
Smaller
Unchanged No assets were unchanged |
Bundle Stats — Flipped aroundHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed No assets were removed Bigger
Smaller
Unchanged No assets were unchanged |
Bundle Stats — Non existentHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged No assets were unchanged |
Bundle Stats — No changesHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — With describe-assets: 'none'Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdown |
Bundle Stats — With describe-assets: 'changed-only'Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller |
| @@ -4,6 +4,9 @@ | |||
| # For our project, we generate this file through a build process from other source files. | |||
| # We need to make sure the checked-in `index.js` actually matches what we expect it to be. | |||
| name: Check dist/ | |||
| permissions: | |||
| contents: read | |||
| pull-requests: write | |||
There was a problem hiding this comment.
does it need this for the upload-artifact?
There was a problem hiding this comment.
The repo says that it needs write permissions:
This action requires the write permission for the [permissions.pull-requests scope](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idpermissions).
| @@ -4,6 +4,9 @@ | |||
| # For our project, we generate this file through a build process from other source files. | |||
| # We need to make sure the checked-in `index.js` actually matches what we expect it to be. | |||
| name: Check dist/ | |||
| permissions: | |||
| contents: read | |||
| pull-requests: write | |||
There was a problem hiding this comment.
| pull-requests: write |
I find it strange that it needs a write-permission on pull-requests when all it does is upload-artifacts.
Can we try without first?
There was a problem hiding this comment.
Actually the repo says that it needs write permissions:
This action requires the write permission for the [permissions.pull-requests scope](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idpermissions).
I am adding permissions to the workflow as described in the code scanning alert: https://github.com/github/webpack-bundlesize-compare-action/security/code-scanning/2