Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to parse output of codeql pack add as JSON #3323

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

shati-patel
Copy link
Contributor

@shati-patel shati-patel commented Feb 7, 2024

Fixes #3219.

The packAdd command is only used in the "Create query" flow, where it was causing some confusing/useless log messages. This is because we were incorrectly expecting JSON output.

I've tested this by running "Create query" and checking that it still works, but doesn't display the following error message

Could not create skeleton QL pack: Parsing output of Adding and installing java pack dependency. failed: Unexpected token 'P', "Package in"... is not valid JSON

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
    • I don't think a changelog update it necessary? It just removes an errant log message 🤔
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This was causing some confusing/useless log messages when running the "Create query" command.
@shati-patel shati-patel marked this pull request as ready for review February 7, 2024 13:57
@shati-patel shati-patel requested a review from a team as a code owner February 7, 2024 13:57
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@shati-patel shati-patel merged commit b418f47 into main Feb 7, 2024
60 checks passed
@shati-patel shati-patel deleted the shati-patel/pack-add-fix branch February 7, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating skeleton query pack logs error
2 participants