-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry for method modeling panel #3041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few comments, but they're all very subjective so please do say if you feel otherwise.
There are also maybe some other interactions, but I don't know if we want to emit telemetry for them or not:
- Changing index (i.e. view next/previous modeling)
- Adding a new modeling
- Removing a modeling
Though adding/removing would also trigger the catch-all "setMultipleModeledMethods" event.
extensions/ql-vscode/src/model-editor/method-modeling/method-modeling-view-provider.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/model-editor/method-modeling/method-modeling-view-provider.ts
Outdated
Show resolved
Hide resolved
Thanks. I've stopped being lazy and added events for those events too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo, otherwise LGTM
extensions/ql-vscode/src/view/method-modeling/MultipleModeledMethodsPanel.tsx
Outdated
Show resolved
Hide resolved
…ethodsPanel.tsx Co-authored-by: Robert <[email protected]>
Adds some telemetry events for interactions with the modeling panel.
The
method-modeling-set-multiple-modeled-methods
is a bit generic, but we can improve that in the future if we want to.Checklist
N/A:
ready-for-doc-review
label there.