Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL CLI download failure causes extension to get stuck #903

Closed
Marcono1234 opened this issue Jul 3, 2021 · 1 comment · Fixed by #3373
Closed

CodeQL CLI download failure causes extension to get stuck #903

Marcono1234 opened this issue Jul 3, 2021 · 1 comment · Fixed by #3373
Labels
bug Something isn't working VSCode

Comments

@Marcono1234
Copy link
Contributor

Describe the bug
It appears when the download of the CodeQL CLI fails, e.g. due to network issues, the extension just gets stuck. No error dialog is shown and nothing is logged.

Have not tested whether this affects other download actions as well, such as downloading databases from LGTM.com.

Version
Extension:

CodeQL extension version: 1.5.1 
CodeQL CLI version: 2.5.7 
Platform: win32 x64

VSCode:

Version: 1.57.1 (user setup)
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:28:07.755Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Windows_NT x64 10.0.19041

To reproduce

  1. If you already have CodeQL CLI downloaded:
    1. Open the CodeQL CLI download folder; on Windows %appdata%\Code\User\globalStorage\github.vscode-codeql
    2. Delete or rename the distribution folder
  2. Start VSCode
  3. Run the command >CodeQL: Check for CLI Updates
  4. While the download is in progress disconnect from the internet
    ❌ The progress gets stuck; nothing happens

Expected behavior
As soon as a download failure occurs the extension should inform the user, and permit restarting the download (currently not possible because current download is not properly cancelled on failure).

Additional context
Maybe error handling also has to be improved; the documentation for pipe says that the destination has to be closed manually on error; it looks like this is currently not done.

@jf205
Copy link
Contributor

jf205 commented Jan 9, 2024

Similar to #3204. We'll look at them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VSCode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants