Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database download gets stuck on connection issues #3204

Closed
Marcono1234 opened this issue Jan 5, 2024 · 1 comment · Fixed by #3373
Closed

Database download gets stuck on connection issues #3204

Marcono1234 opened this issue Jan 5, 2024 · 1 comment · Fixed by #3373
Labels
bug Something isn't working VSCode

Comments

@Marcono1234
Copy link
Contributor

Describe the bug
When a network connection issue occurs while downloading a database (from GitHub), the download just gets stuck. No error is reported, nothing is logged and when the network connection is restored the download does not continue either.

Possibly related to #903

Version
Extension:

CodeQL extension version: 1.11.0 
CodeQL CLI version: 2.15.5 
Platform: win32 x64

VS Code:

Version: 1.85.1 (user setup)
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:49:37.021Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.19045

To reproduce

  1. Start the download of a large CodeQL database, for example the Java database for https://github.com/elastic/elasticsearch (~300 MB)
  2. While the download is in progress, disconnect from the internet
  3. Wait some time, optionally reconnect to the internet
    ❌ Bug: Nothing happens, the download progress notification is stuck

Expected behavior
Either:

  • The download should fail and an error should be reported
  • Or, a warning or error should be shown / logged and the download should continue once the internet connection is restored
@Marcono1234 Marcono1234 added the bug Something isn't working label Jan 5, 2024
@github-actions github-actions bot added the VSCode label Jan 5, 2024
@jf205
Copy link
Contributor

jf205 commented Jan 9, 2024

Thanks @Marcono1234. I think we can do a better job with the UX in this case. You may be right that it is related to #903. We will discuss and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VSCode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants