Don't spam the logs.

github · Jul 9, 2024 · c08b38b · c08b38b
1 parent 697a53d
commit c08b38b
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/go/vt/discovery/healthcheck.go b/go/vt/discovery/healthcheck.go
@@ -533,10 +533,13 @@ func (hc *HealthCheckImpl) updateHealth(th *TabletHealth, prevTarget *query.Targ
 					th.PrimaryTermStartTime,
 					hc.healthy[targetKey][0].PrimaryTermStartTime)
 			} else {
-				log.Warningf("new healthy primary %s for %s is up, replacing previous primary %s",
-					topoproto.TabletAliasString(th.Tablet.Alias),
-					topoproto.KeyspaceShardString(th.Target.Keyspace, th.Target.Shard),
-					topoproto.TabletAliasString(hc.healthy[targetKey][0].Tablet.Alias))
+				if hc.healthy[targetKey][0].Tablet.Alias != th.Tablet.Alias {
+					log.Warningf("new healthy primary %s for %s is up, replacing previous primary %s",
+						topoproto.TabletAliasString(th.Tablet.Alias),
+						topoproto.KeyspaceShardString(th.Target.Keyspace, th.Target.Shard),
+						topoproto.TabletAliasString(hc.healthy[targetKey][0].Tablet.Alias))
+				}
+
 				// Just replace it.
 				hc.healthy[targetKey][0] = th
 			}