Ensure tabs are available before selecting #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experienced an error thrown from this element in dotcom today:
Our error reporting system indicated the error was thrown in
selectTab
, which was called fromconnectedCallback
. It's not entirely clear what's happening, but one possible cause is that the list of tabs may not be available whenconnectedCallback
is invoked. This PR uses aMutationObserver
to ensure that the tabs are available before callingselectTab
. This will hopefully prevent the error from occurring. I also removed the throw statement in question, opting instead for an early return.