Add addon overhead benchmark baseline - #161
Open
mattcosta7 wants to merge 1 commit into
Open
Conversation
mattcosta7
marked this pull request as draft
August 3, 2026 13:29
Contributor
There was a problem hiding this comment.
Pull request overview
Adds diagnostic browser benchmarks to establish addon overhead baselines.
Changes:
- Benchmarks lifecycle, DOM mutation, and React workloads across three addon states.
- Adds benchmark commands, documentation, JSON output, and CI artifact upload.
- Pins experimental Vitest benchmark dependencies to 4.1.10.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci.yml |
Runs and uploads benchmark results. |
.gitignore |
Ignores generated benchmark JSON. |
CONTRIBUTING.md |
Documents benchmark usage. |
package.json |
Adds the root benchmark command. |
package-lock.json |
Records exact Vitest versions. |
packages/storybook-addon-performance-panel/package.json |
Adds workspace command and pins dependencies. |
packages/storybook-addon-performance-panel/vitest.benchmark.config.ts |
Configures headless Chromium benchmarks. |
packages/storybook-addon-performance-panel/__benchmarks__/overhead.browser.bench.tsx |
Implements overhead workloads and scenarios. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/8 changed files
- Comments generated: 0
- Review effort level: Balanced
This was referenced Aug 3, 2026
mattcosta7
marked this pull request as ready for review
August 3, 2026 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--comparecommandsThe CI benchmark is a functional check only. Its measurements remain diagnostic until repeated runs establish stable variance and defensible budgets.
Validation
npm run benchmarknpm run benchmark -- --compare <baseline.json>npm run tscnpm run lint(passes with one existing warning in the forced-reflow collector test)No changeset is included because this only adds development and CI measurement infrastructure.