Pause frame metrics while previews are hidden - #157
Merged
Conversation
This was referenced Aug 3, 2026
mattcosta7
temporarily deployed
to
github-pages-preview
August 3, 2026 00:26 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Makes frame timing lifecycle-aware, preventing hidden previews and startup baselines from producing false regressions.
Changes:
- Establishes fresh RAF baselines on start, reset, and visibility restoration.
- Pauses collection while hidden and makes lifecycle calls idempotent.
- Updates browser tests and release metadata.
Show a summary per file
| File | Description |
|---|---|
frame-timing-collector.ts |
Adds visibility-aware RAF lifecycle handling. |
frame-timing-collector.browser.test.ts |
Tests baseline and visibility behavior. |
collector-manager.browser.test.ts |
Adapts frame collection test to baseline seeding. |
.changeset/frame-lifecycle.md |
Documents the patch release. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
mattcosta7
marked this pull request as draft
August 3, 2026 00:31
mattcosta7
force-pushed
the
v1.2/02-frame-lifecycle
branch
from
August 3, 2026 02:14
7a2fd92 to
0bd63b9
Compare
mattcosta7
temporarily deployed
to
github-pages-preview
August 3, 2026 02:15 — with
GitHub Actions
Inactive
mattcosta7
force-pushed
the
v1.2/02-frame-lifecycle
branch
from
August 3, 2026 04:24
0bd63b9 to
a6becbd
Compare
mattcosta7
temporarily deployed
to
github-pages-preview
August 3, 2026 04:25 — with
GitHub Actions
Inactive
mattcosta7
temporarily deployed
to
github-pages-preview
August 3, 2026 12:23 — with
GitHub Actions
Inactive
mattcosta7
temporarily deployed
to
github-pages-preview
August 3, 2026 12:39 — with
GitHub Actions
Inactive
mattcosta7
marked this pull request as ready for review
August 3, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make frame timing lifecycle-aware so inactive previews do not create false performance regressions.
Stack
Validation
npm run tscnpm run lint(one pre-existing unused suppression warning)