fix: replace print() with logger.warning() in extensions catalog warnings - #3969
Open
Quratulain-bilal wants to merge 1 commit into
Open
fix: replace print() with logger.warning() in extensions catalog warnings#3969Quratulain-bilal wants to merge 1 commit into
Quratulain-bilal wants to merge 1 commit into
Conversation
…ings Print statements to stderr are not appropriate for library code that may be consumed by tools or tests. Replaced with logger.warning() for proper log management. Removed unused local sys imports.
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces direct stderr warnings with standard Python logging in the extension catalog.
Changes:
- Added a module logger.
- Migrated two catalog warnings to
logger.warning(). - Removed unused local
sysimports.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/extensions/__init__.py |
Routes catalog warnings through logging. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (1)
src/specify_cli/extensions/init.py:3757
- Please cover the partial-fetch failure path with
caplog: make one catalog raiseExtensionError, let another succeed, and assert the named warning is logged while merging continues. This is the second logging behavior changed by the PR and currently has no regression test.
logger.warning(
"Could not fetch catalog '%s': %s", catalog_entry.name, e,
)
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+3520
to
3523
| logger.warning( | ||
| "Using non-default extension catalog. " | ||
| "Only use catalogs from sources you trust.", | ||
| file=sys.stderr, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
print(..., file=sys.stderr) is inappropriate for library code - it bypasses the logging framework and can't be silenced or redirected by consumers.
Fix
Replaced with logger.warning() for proper log management. Removed unused local sys imports.