feat(extensions): add --force flag to extension add for overwrite reinstall by grissiom · Pull Request #2530 · github/spec-kit

grissiom · 2026-05-12T15:26:00Z

feat(extensions): add --force flag to extension add for overwrite reinstall

Add --force support to specify extension add that allows overwriting an already-installed extension without manually removing it first.

install_from_directory() and install_from_zip() accept force=True, automatically calling remove() before installation
The --force CLI flag works with all install modes (--dev, --from URL, bundled, and catalog)
Config files (*-config.yml) are preserved across force reinstall
Error message suggests --force when extension is already installed
6 new tests covering unit and CLI force reinstall flows

Description

If the extension is updated, --force could eliminate the remove/install loop and simplify the workflow.

Testing

Tested locally with uv run specify --help
Ran existing tests with uv sync && uv run pytest
Tested with a sample project (if applicable)

AI Disclosure

I did not use AI assistance for this contribution
I did use AI assistance (describe below)

Generated by Copilot(model: DeepSeek-V4).

Copilot

Pull request overview

Adds --force support to specify extension add so users can overwrite/reinstall an already-installed extension in one step, while preserving *-config.yml files across the reinstall.

Changes:

Add force parameter to ExtensionManager.install_from_directory() / install_from_zip() and plumb --force through the CLI.
Preserve extension config files across force reinstalls via .specify/extensions/.backup/<ext_id> restore logic.
Add unit + CLI tests for force reinstall behavior and updated duplicate-install error messaging.

Show a summary per file

File	Description
`src/specify_cli/extensions.py`	Implements `force` reinstall path, updated duplicate install error text, and config backup restore.
`src/specify_cli/__init__.py`	Adds `--force` flag to `specify extension add` and passes it through to install routines.
`tests/test_extensions.py`	Adds tests for force reinstall flows (directory/zip) and CLI coverage for `extension add --dev --force`.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 3/3 changed files
Comments generated: 3

mnriem · 2026-05-12T17:26:13Z

Please address Copilot feedback

grissiom · 2026-05-13T13:43:17Z

@mnriem fixed the 3 comments, please review it again. Thanks~

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 1

mnriem

Please address Copilot feedback

grissiom · 2026-05-16T10:35:34Z

@mnriem Thank you for your review. The bug is fixed. Please review it again. Thanks~

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 3

mnriem

Please address Copilot feedback. If not applicable, please explain why

grissiom · 2026-05-23T04:34:11Z

Nice findings @mnriem , all issues fixed and please review it again. Thanks~

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 3

mnriem · 2026-05-27T12:42:47Z

Please address Copilot feedback. If not applicable, please explain why

grissiom · 2026-05-30T04:20:47Z

Thank you @mnriem , all feedback fixed and the PR branch rebased to the main. Please review it again. Thanks~

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 3

mnriem · 2026-06-01T20:04:59Z

Please address Copilot feedback and resolve conflicts

…nstall Add --force support to `specify extension add` that allows overwriting an already-installed extension without manually removing it first. - install_from_directory() and install_from_zip() accept force=True, automatically calling remove() before installation - The --force CLI flag works with all install modes (--dev, --from URL, bundled, and catalog) - Config files (*-config.yml) are preserved across force reinstall - Error message suggests --force when extension is already installed - 6 new tests covering unit and CLI force reinstall flows

- Remove unused `backup_config_dir` variable assignment (Ruff F841) - Defer `remove()` until after `_validate_install_conflicts()` to prevent data loss if validation fails mid-reinstall - Use `TemporaryDirectory` instead of `NamedTemporaryFile` in ZIP test to avoid Windows file-locking failures

When --force is used but the extension is not already installed, the backup restore/cleanup should not run. Previously it could resurrect stale config files from a previous removal and delete the backup directory unnecessarily.

- Clear stale backup dir before remove() so only fresh backups are restored - Restore only config files (*-config.yml, *-config.local.yml) from backup - Remove trailing \n from --force console message (console.print adds newline)

- Use is_dir() before rmtree/iterdir on backup path to avoid crashes when .backup/<id> exists as a file or symlink - Remove unused manifest1 variable in test_install_force_reinstall

- Check is_symlink() before is_dir() in backup cleanup and restore: Path.is_dir() follows symlinks (returns True for symlink-to-dir) but shutil.rmtree() raises OSError on symlinks. Handle symlinks by unlinking them instead. - Skip symlink entries during config file restore. - Change --force dev-install message from "Reinstalling" to "Installing [...] (will overwrite if already installed)" because --force also works for first-time installs.

grissiom · 2026-06-03T15:11:35Z

Hello @mnriem , all the comment fixed and branch rebased. Please review it again. Thank you for your patience.

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 0 new

mnriem · 2026-06-03T21:34:32Z

Thank you!

grissiom requested a review from mnriem as a code owner May 12, 2026 15:26

mnriem requested a review from Copilot May 12, 2026 16:27

Copilot AI reviewed May 12, 2026

View reviewed changes

Comment thread src/specify_cli/extensions.py Outdated

Comment thread src/specify_cli/extensions.py

Comment thread tests/test_extensions.py Outdated

mnriem requested a review from Copilot May 13, 2026 14:38

Copilot started reviewing on behalf of mnriem May 13, 2026 14:39 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread src/specify_cli/extensions.py Outdated

mnriem requested changes May 13, 2026

View reviewed changes

grissiom requested a review from mnriem May 18, 2026 12:56

mnriem requested a review from Copilot May 21, 2026 00:28

Copilot started reviewing on behalf of mnriem May 21, 2026 00:28 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread src/specify_cli/extensions.py

Comment thread src/specify_cli/extensions.py Outdated

Comment thread src/specify_cli/__init__.py Outdated

mnriem requested changes May 21, 2026

View reviewed changes

grissiom force-pushed the feat/extension-add-force branch from 355a649 to 1ed5439 Compare May 23, 2026 04:33

mnriem requested a review from Copilot May 26, 2026 17:46

Copilot started reviewing on behalf of mnriem May 26, 2026 17:47 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

Comment thread src/specify_cli/extensions.py Outdated

Comment thread src/specify_cli/extensions.py

Comment thread tests/test_extensions.py

grissiom force-pushed the feat/extension-add-force branch from 93cf642 to bd1cea9 Compare May 30, 2026 04:19

mnriem requested a review from Copilot June 1, 2026 15:15

Copilot started reviewing on behalf of mnriem June 1, 2026 15:16 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread src/specify_cli/extensions.py

Comment thread src/specify_cli/extensions.py

Comment thread src/specify_cli/__init__.py

grissiom added 3 commits June 3, 2026 23:09

fix: handle non-directory paths in backup cleanup/restore

3b711a3

- Use is_dir() before rmtree/iterdir on backup path to avoid crashes when .backup/<id> exists as a file or symlink - Remove unused manifest1 variable in test_install_force_reinstall

grissiom force-pushed the feat/extension-add-force branch from d322332 to 5b97266 Compare June 3, 2026 15:09

mnriem requested a review from Copilot June 3, 2026 19:36

Copilot started reviewing on behalf of mnriem June 3, 2026 19:36 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

mnriem self-requested a review June 3, 2026 21:33

mnriem approved these changes Jun 3, 2026

View reviewed changes

mnriem merged commit 659a41a into github:main Jun 3, 2026
11 checks passed

Conversation

grissiom commented May 12, 2026

Description

Testing

AI Disclosure

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnriem commented May 12, 2026

Uh oh!

grissiom commented May 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

mnriem left a comment

Choose a reason for hiding this comment

Uh oh!

grissiom commented May 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnriem left a comment

Choose a reason for hiding this comment

Uh oh!

grissiom commented May 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnriem commented May 27, 2026

Uh oh!

grissiom commented May 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnriem commented Jun 1, 2026

Uh oh!

grissiom commented Jun 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

mnriem commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants