Fix environment creation with prevent_self_review #630
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #628
Implements validation and error handling for environment creation with
prevent_self_review
enabled inlib/plugins/environments.js
.prevent_self_review
is set totrue
. This prevents the creation of environments without reviewers, addressing the issue where environments were partially created on the first attempt and required a restart to complete.prevent_self_review
are created successfully in a single pass, eliminating the need for partial provisioning or errors that lead to pod restarts.