-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding external runner for doing a one-time full-sync #604
base: main-enterprise
Are you sure you want to change the base?
Conversation
I realized that my initial version of full-sync did not return a non-zero exit code when errors occurred, so I updated it to check If someone has a cleaner option for this error checking, please let me know |
We could look into using checks to communicate errors back to the Actions workflow. |
Yea, tying into Checks would make things cleaner. I'm not familiar with the feature or code in detail, so if anyone has tips/suggestions, let me know. The other question I had was if the probot gha adapter would help with error collecting, but it doesn't look like the Settings class is sending probot error info, so maybe it wouldn't help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pydolan I think this is a cool addition. Would you be able to add information about this in the README?
@decyjphr - this is still on my radar; will try to get to it soon! |
@decyjphr and others – thanks for your patience on me getting back to this. I rebased my branch and updated the documentation with details on running |
Summary:
This is a potential way of addressing #378 and #379.
As noted on #378, I'm using this along with the following for triggering safe-settings via GHA:
Additional comments:
syncInstallation
using index.js/package.json, I'm happy to change this.settings.errors
. I didn't see a way to check the errors from my syncInstallation call, so I modifiedSettings.syncAll
to return itssettings
object. If someone has a cleaner option for this error checking, please let me know.